[wplug] Linux vs OS X version of GCC

Logan ascii at psu.edu
Thu Apr 20 12:35:21 EDT 2006


> And there is no way you should even attempt to write that code, the
> logic behind it is so incredibly broken it's not funny.
> Seriously did anyone even read it?
>
>> int stringLgn = strlen(args[arg_count]);
>
> _requires_ that args[arg_count] be null terminated.
>
>> args[arg_count][strinLgn] = 0;
>
> for the previous statement to work (strlen()), this must already hold
> true..
>
> The code was 100% redundant and all it did was introduce bugs.

not so much redundant as broken, it should have been strlen(start)
but yes, now that I look at it, it is rather silly :-\


More information about the wplug mailing list